[ 
https://issues.apache.org/jira/browse/YARN-10304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17129100#comment-17129100
 ] 

Andras Gyori commented on YARN-10304:
-------------------------------------

Thank you [~adam.antal] for the thorough feedback. I completely agree with you, 
as enclosing the more complex path assembler logic would be way out of scope, 
and probably will be a massive undertaking. For now, I have removed the new 
class, as the logic of path assembly is minimal, and the rest of the code is 
just boilerplate.  That being said, I have only made one test case to prove 
that the endpoint is working, because the logic of creating the path is tested 
elsewhere.
I have addressed each of your concerns and uploaded a new patch set.

> Create an endpoint for remote application log directory path query
> ------------------------------------------------------------------
>
>                 Key: YARN-10304
>                 URL: https://issues.apache.org/jira/browse/YARN-10304
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Andras Gyori
>            Assignee: Andras Gyori
>            Priority: Minor
>         Attachments: YARN-10304.001.patch, YARN-10304.002.patch
>
>
> The logic of the aggregated log directory path determination (currently based 
> on configuration) is scattered around the codebase and duplicated multiple 
> times. By providing a separate class for creating the path for a specific 
> user, it allows for an abstraction over this logic. This could be used in 
> place of the previously duplicated logic, moreover, we could provide an 
> endpoint to query this path.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to