[ 
https://issues.apache.org/jira/browse/YARN-10321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141756#comment-17141756
 ] 

Prabhu Joseph commented on YARN-10321:
--------------------------------------

Thanks [~snemeth] for the patch and [~shuzirra] for the review.

The patch looks good, +1. Have committed it to trunk.

> Break down TestUserGroupMappingPlacementRule#testMapping into test scenarios
> ----------------------------------------------------------------------------
>
>                 Key: YARN-10321
>                 URL: https://issues.apache.org/jira/browse/YARN-10321
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Szilard Nemeth
>            Assignee: Szilard Nemeth
>            Priority: Minor
>         Attachments: YARN-10321.001.patch
>
>
> org.apache.hadoop.yarn.server.resourcemanager.placement.TestUserGroupMappingPlacementRule#testMapping
>  is very large and hard to read/maintain and moreover, error-prone.
> We should break this testcase down into several separate testcases.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to