[
https://issues.apache.org/jira/browse/YARN-10277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143721#comment-17143721
]
Peter Bacsko commented on YARN-10277:
-------------------------------------
Looks good to me, but can we get rid of the checkstyle problems?
> CapacityScheduler test TestUserGroupMappingPlacementRule should build proper
> hierarchy
> --------------------------------------------------------------------------------------
>
> Key: YARN-10277
> URL: https://issues.apache.org/jira/browse/YARN-10277
> Project: Hadoop YARN
> Issue Type: Task
> Reporter: Gergely Pollak
> Assignee: Szilard Nemeth
> Priority: Major
> Attachments: YARN-10277.001.patch, YARN-10277.002.patch
>
>
> Since the CapacityScheduler internal implementation depends more and more on
> queue being hierarchical, the test gets really hard to maintain. A lot of
> test cases were failing because they used non existing queues, but the older
> placement rule solution ignored missing parents, but since the leaf queue
> change in CS, we must be able to get a full path for any queue, since all
> queues are referenced by their full path.
> This test should reflect this and instead of creating and expecting the
> existance of fictional queues, it should create a proper queue hierarchy,
> with a way to describe it better.
> Currently we set up a bunch of mockito "when" statements to simulate the
> queue behavior, but this is a hassle to maintain, and easy to miss a few
> method.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
