[ 
https://issues.apache.org/jira/browse/YARN-10327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145010#comment-17145010
 ] 

Andras Gyori commented on YARN-10327:
-------------------------------------

Thank you for working on this issue [~mhudaky]. The patch looks good to me. 
Following the same logic, there are invalidOpts as well, that could belong to 
testLogsCLIWithInvalidArgs method. However, for this issue, I think it is 
enough.

> Remove duplication of checking for invalid application ID in TestLogsCLI
> ------------------------------------------------------------------------
>
>                 Key: YARN-10327
>                 URL: https://issues.apache.org/jira/browse/YARN-10327
>             Project: Hadoop YARN
>          Issue Type: Test
>            Reporter: Hudáky Márton Gyula
>            Assignee: Hudáky Márton Gyula
>            Priority: Trivial
>         Attachments: YARN-10327.001.patch
>
>
> TestLogsCLI has a separate function to test for invalid application ID 
> (#testInvalidApplicationId) and another (#testLogsCLIWithInvalidArgs) to test 
> multiple invalid arguments (including application ID). One of them should be 
> eliminated.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to