[ 
https://issues.apache.org/jira/browse/YARN-10279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145021#comment-17145021
 ] 

Szilard Nemeth commented on YARN-10279:
---------------------------------------

Thanks [~mhudaky],
Latest patch LGTM, committed to trunk and branch-3.3
Thanks [~adam.antal] for the review.

Thanks [~mhudaky] for filing the FS flaky jira as well.
Resolving this jira.

> Avoid unnecessary QueueMappingEntity creations
> ----------------------------------------------
>
>                 Key: YARN-10279
>                 URL: https://issues.apache.org/jira/browse/YARN-10279
>             Project: Hadoop YARN
>          Issue Type: Task
>            Reporter: Gergely Pollak
>            Assignee: Hudáky Márton Gyula
>            Priority: Minor
>         Attachments: YARN-10279.001.patch, YARN-10279.003.patch, 
> YARN-10279.004.patch, YARN-10279.005.patch, YARN-10279.006.patch
>
>
> In CS UserGroupMappingPlacementRule and AppNameMappingPlacementRule classes 
> we create new instances of QueueMappingEntity class. In some cases we simply 
> copy the already received class, so we just duplicate it, which is 
> unnecessary since the class is immutable.
> This is just a minor improvement, probably doesn't have much impact, but 
> still puts some unnecessary load on GC.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to