[ 
https://issues.apache.org/jira/browse/YARN-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145782#comment-17145782
 ] 

Jim Brennan commented on YARN-10251:
------------------------------------

Thanks for the patch [~epayne]! Overall I think this looks good. I have a few 
comments:


 AppInfo
 - (nit) move the initialization of {{usageReport}} before the if statement so 
you can use it throughout that condition. Makes the diff a little bigger, but I 
think it’s worth it in this case.

NodesPage
 - The new entries for {{GPUs Used}} and {{GPUs Avail}} are still using 
{{".vcores”}} for the set selector. Is this correct? Shouldn't we use 
{{".gpus"}}?
{noformat}
.th(".vcores", "GPUs Used")
.th(".vcores", "GPUs Avail");
{noformat}

RmAppsBlock
 - I'm not sure I understand this logic:
{noformat}
        .append((isAppInCompletedState && app.getAllocatedGpus() <= 0)
            ? "N/A" : String.valueOf(app.getAllocatedGpus()))
{noformat}
So if the app is not in a completed state we don't need to check for 
app.getAllocatedGpus() <= 0)?
 Should that check be {{(isAppInCompletedState || app.getAllocatedGpus() <= 
0)}} ?

 - also, should that be checking for {{< 0}} or {{== -1}} instead?
 - replace "N/A" with UNAVAILABLE, which is defined to the same thing.

> Show extended resources on legacy RM UI.
> ----------------------------------------
>
>                 Key: YARN-10251
>                 URL: https://issues.apache.org/jira/browse/YARN-10251
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Eric Payne
>            Assignee: Eric Payne
>            Priority: Major
>         Attachments: Legacy RM UI With Not All Resources Shown.png, Updated 
> NodesPage UI With GPU columns.png, Updated RM UI With All Resources 
> Shown.png.png, YARN-10251.003.patch, YARN-10251.004.patch, 
> YARN-10251.005.patch, YARN-10251.branch-2.10.001.patch, 
> YARN-10251.branch-2.10.002.patch, YARN-10251.branch-2.10.003.patch, 
> YARN-10251.branch-2.10.005.patch, YARN-10251.branch-3.2.004.patch, 
> YARN-10251.branch-3.2.005.patch
>
>
> It would be great to update the legacy RM UI to include GPU resources in the 
> overview and in the per-app sections.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to