Jim Brennan commented on YARN-9809:

Thanks for the updates [~ebadger]!   I have one comment on the new patch:

* I think there's a bug from moving the call to 
\{{ClusterMetrics.getMetrics().incrNumActiveNodes()}}.  If previousRMNode != 
null (in the first check), we call \{{rmNode.updateMetricsForRejoinedNode()}}, 
which decrements the counter for the previous state and increments num active 
nodes. With your change, we now increment active nodes again when we call 

> NMs should supply a health status when registering with RM
> ----------------------------------------------------------
>                 Key: YARN-9809
>                 URL: https://issues.apache.org/jira/browse/YARN-9809
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Eric Badger
>            Assignee: Eric Badger
>            Priority: Major
>         Attachments: YARN-9809.001.patch, YARN-9809.002.patch, 
> YARN-9809.003.patch, YARN-9809.004.patch, YARN-9809.005.patch, 
> YARN-9809.006.patch
> Currently if the NM registers with the RM and it is unhealthy, it can be 
> scheduled many containers before the first heartbeat. After the first 
> heartbeat, the RM will mark the NM as unhealthy and kill all of the 
> containers.

This message was sent by Atlassian Jira

To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to