Adam Antal commented on YARN-10319:

Thanks for the patch [~prabhujoseph]. I have some minor nits if you don't mind.

- In {{RMWebServices}} I took a look at how the scheduler and pre-checks are 
performed for the existing {{#getActivities}} function, and it seems to me that 
there are some duplicates. I think the checks (choosing the scheduler, getting 
the {{ActivitiesManager}}) can be moved to a separate function that can be used 
by both endpoints. I think it would be nice, if we could provide the same error 
if not CS is used (I'm especially thinking about 
- Let's {{RESTClient}} be private in {{ActivitiesTestUtils}}.
- Could you please also add an example output for {{/bulk-activities}} into 

> Record Last N Scheduler Activities from ActivitiesManager
> ---------------------------------------------------------
>                 Key: YARN-10319
>                 URL: https://issues.apache.org/jira/browse/YARN-10319
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 3.3.0
>            Reporter: Prabhu Joseph
>            Assignee: Prabhu Joseph
>            Priority: Major
>              Labels: activitiesmanager
>         Attachments: Screen Shot 2020-06-18 at 1.26.31 PM.png, 
> YARN-10319-001-WIP.patch, YARN-10319-002.patch, YARN-10319-003.patch, 
> YARN-10319-004.patch
> ActivitiesManager records a call flow for a given nodeId or a last call flow. 
> This is useful when debugging the issue live where the user queries with 
> right nodeId. But capturing last N scheduler activities during the issue 
> period can help to debug the issue offline.

This message was sent by Atlassian Jira

To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to