[ 
https://issues.apache.org/jira/browse/YARN-9136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17168586#comment-17168586
 ] 

Szilard Nemeth commented on YARN-9136:
--------------------------------------

Hi [~mhudaky]!

1. Comment to the part that describes response for FPGA devices: 
{code}
The response to this request if there are FPGA device(s) present
{code}

Looking at this method: 
org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.fpga.FpgaResourcePlugin#getNMResourceInfo,
 it seems in case of FpgaResourcePlugin, the response is empty so the response 
won't have the list of NMDeviceResourceInfo objects serialized.
How did you come to the conclusion that these type of objects are being 
serialized in case of FPGA devices are present?
I'm not sure in case of FPGa, the method 
org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.deviceframework.DevicePluginAdapter#getNMResourceInfo
 or the same method of FpgaResourcePlugin will be invoked.
[~pbacsko] Can you help with this?

2. Nit: With 2 occurrences, you have: 
{code}
AssignedDevice include container ID
{code}
include should be includes.

3. GPU devices can be manually configured, nvidia-smi is not a prerequisite 
software to install to the system:
{code}
Contains all GPU Device Information in the system, fetched from nvidia-smi.
{code}
Please remove any reference to nvidia-smi.



> getNMResourceInfo NodeManager REST API method is not documented
> ---------------------------------------------------------------
>
>                 Key: YARN-9136
>                 URL: https://issues.apache.org/jira/browse/YARN-9136
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Szilard Nemeth
>            Assignee: Hudáky Márton Gyula
>            Priority: Major
>         Attachments: YARN-9136.001.patch, YARN-9136.002.patch
>
>
> I cannot find documentation for the resources endpoint in NMWebServices: 
> /ws/v1/node/resources/\{resourcename\}
> I looked in the file NodeManagerRest.md for documentation but haven't found 
> any.
> This is supposedly unintentionally not documented: 
> https://github.com/apache/hadoop/blob/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/NodeManagerRest.md



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to