[ https://issues.apache.org/jira/browse/YARN-10389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17174941#comment-17174941 ]
Prabhu Joseph commented on YARN-10389: -------------------------------------- [~tanu.ajmera] Thanks for the patch. The patch looks good. One minor issue which is not related to this patch. 1. The below null check is not required {code} bindExternalClasses(); if (rm != null) {code} rm gets accessed even before the null check from bindExternalClasses, so no use having the null check. {code} private void bindExternalClasses() { YarnConfiguration yarnConf = new YarnConfiguration(rm.getConfig()); {codE} > Option to override RMWebServices with custom WebService class > ------------------------------------------------------------- > > Key: YARN-10389 > URL: https://issues.apache.org/jira/browse/YARN-10389 > Project: Hadoop YARN > Issue Type: Improvement > Affects Versions: 3.4.0 > Reporter: Prabhu Joseph > Assignee: Tanu Ajmera > Priority: Major > Attachments: YARN-10389-001.patch, YARN-10389-002.patch, > YARN-10389-003.patch, YARN-10389-004.patch, YARN-10389-005.patch, > YARN-10389-006.patch, YARN-10389-007.patch > > > YARN-8047 provides support to add custom WebServices as part of RMWebApp. > Since each WebService has to have a separate WebService Path, /ws/v1/cluster > root path cannot be used globally. > Another alternative is to provide an option to override the RMWebServices > with custom WebServices implementation which can extend the RMWebService, > this way /ws/v1/cluster path can be used globally. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org