[
https://issues.apache.org/jira/browse/YARN-10391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17179019#comment-17179019
]
Jim Brennan commented on YARN-10391:
------------------------------------
The unit test failure is unrelated, and I don't think we need a new test for
this.
Technically, these --module options shouldn't be doing the work in the
validate_arguments() function, they should set an operation code and call the
function that does the work in main like the others.
But I am ok with just fixing this bug as you have done here. The comment makes
it clear what is going on.
I'm +1 on this. Will commit later today.
> --module-gpu functionality is broken in container-executor
> ----------------------------------------------------------
>
> Key: YARN-10391
> URL: https://issues.apache.org/jira/browse/YARN-10391
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 3.3.0
> Reporter: Eric Badger
> Assignee: Eric Badger
> Priority: Major
> Attachments: YARN-10391.001.patch
>
>
> {{--module-gpu}} doesn't set the {{operation}} variable, and so the
> {{main()}} function's switch statement on {{operation}} falls through to the
> default case. This causes it to report a failure, even though it succeeded.
> {noformat}
> default:
> fprintf(ERRORFILE, "Unexpected operation code: %d\n", operation);
> exit_code = INVALID_COMMAND_PROVIDED;
> break;
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
