[
https://issues.apache.org/jira/browse/YARN-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185764#comment-17185764
]
Adam Antal commented on YARN-10386:
-----------------------------------
Thanks for working on this [~pbacsko].
I saw you had some troubles with the jenkins. I don't see what exactly causes
the jenkins failures but we should make sure that after we merge this, it won't
appear in other jenkins results.
Regarding the patch I have two comments:
I am a little concerned about the checkstyle ignores:
{noformat}
@SuppressWarnings({"checkstyle:hideutilityclassconstructor",
"checkstyle:linelength"})
{noformat}
- I don't see problems creating a private constructor for this class to prevent
instantiation of this utility class.
- Also, this can be moved to a constant: {{
"org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.placement.schema",}}
any maybe we can add the checkstyle warning annotation to only to the constant
to be as restrictive as we can.
Other:
- In {{hadoop-yarn-server-resourcemanager/pom.xml}} can we also use the
${jsonschema2pojo.version} constant for the version if possible?
I also add that I checked the new maven dependency and I saw no associated
CVE-s to that, so I think it's fine to use it.
> Create new JSON schema for Placement Rules
> ------------------------------------------
>
> Key: YARN-10386
> URL: https://issues.apache.org/jira/browse/YARN-10386
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: capacity scheduler, capacityscheduler
> Reporter: Peter Bacsko
> Assignee: Peter Bacsko
> Priority: Major
> Attachments: MappingRulesDescription_v1.json, YARN-10386-001.patch,
> YARN-10386-002.patch, YARN-10386-003.patch, YARN-10386-004.patch,
> YARN-10386-005.patch, YARN-10386-006.patch
>
>
> Tasks in this JIRA:
> # Create new JSON schema
> # Add Maven plugin which generates Java POJOs based on the schema
> # Add helper class which essentially does the same as #2 (for dev purposes)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
