[
https://issues.apache.org/jira/browse/YARN-10373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186660#comment-17186660
]
Szilard Nemeth commented on YARN-10373:
---------------------------------------
[~shuzirra]
Thanks for working on this, good job!
Again, I liked the testcases added with the patch.
Some comments:
1. Nit: There are some C-style array declarations in the class, which could be
replaced with Java-style, for example:
{code:java}
private MappingRuleMatcher matchers[];
{code}
should rather be:
{code}
private MappingRuleMatcher[] matchers;
{code}
2. In MappingRuleMatchers.AndMatcher#match: I think the matcher that wasn't
matching should be logged, also the remaining / passed matchers could be useful
in a debug level log.
What do you think?
3. Similarly with MappingRuleMatchers.OrMatcher#match, logging could be added.
4. Nit, javadoc of MappingRuleMatchers.OrMatcher: it's --> its
5. Typo in javadoc of MappingRuleMatchers#createUserGroupMatcher: agains -->
against
> Create Matchers for CS mapping rules
> ------------------------------------
>
> Key: YARN-10373
> URL: https://issues.apache.org/jira/browse/YARN-10373
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: yarn
> Reporter: Gergely Pollak
> Assignee: Gergely Pollak
> Priority: Major
> Attachments: YARN-10373.001.patch
>
>
> As per the design document attached to the umbrella Jira (YARN-10370), we
> need to create the classes which represent the different ways we can decide
> if a mapping rule applies to an application placement. There are multiple
> matchers to be implemented, like user matcher, application name matcher,
> group matcher, catch all.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
