[ 
https://issues.apache.org/jira/browse/YARN-10424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192283#comment-17192283
 ] 

Benjamin Teke commented on YARN-10424:
--------------------------------------

[~snemeth], thanks for looking at the patch. Fixed the checkstyle issues except 
for two cases where the existing test name exceeds the line length limit. Not 
sure if it's worth it to modify the name to fix the issue, as the test cases 
are (mostly) untouched to prove the backward compatibility of the new placement 
engine.

> Adapt existing AppName and UserGroupMapping unittests to ensure backwards 
> compatibility
> ---------------------------------------------------------------------------------------
>
>                 Key: YARN-10424
>                 URL: https://issues.apache.org/jira/browse/YARN-10424
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Benjamin Teke
>            Assignee: Benjamin Teke
>            Priority: Major
>         Attachments: YARN-10424.001.patch, YARN-10424.002.patch, 
> YARN-10424.003.patch
>
>
> The class {{UserGroupMappingPlacementRule}} and 
> {{AppNameMappingPlacementRule}} will disappear. In order to ensure backwards 
> compatibility when the configuration is defined in the legacy format, 
> {{TestAppNameMappingPlacementRule}} and {{TestUserGroupMappingPlacementRule}} 
> should be adapted to use the new evaluator logic.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to