[jira] [Commented] (YARN-1332) In TestAMRMClient, replace assertTrue with assertEquals where possible

[Sandy Ryza (JIRA)]

    [ 
https://issues.apache.org/jira/browse/YARN-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824032#comment-13824032
 ] 

Sandy Ryza commented on YARN-1332:
----------------------------------

Thanks for picking this up Sebastian.  There are a few places assertEquals 
could be substituted for assertTrue for non-zero values.  For example:
{code}
     assertTrue(allocatedContainerCount == containersRequestedAny);
     assertTrue(amClient.release.size() == 2);
{code}
Would you mind replacing those too?

> In TestAMRMClient, replace assertTrue with assertEquals where possible
> ----------------------------------------------------------------------
>
>                 Key: YARN-1332
>                 URL: https://issues.apache.org/jira/browse/YARN-1332
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.2.0
>            Reporter: Sandy Ryza
>            Priority: Minor
>              Labels: newbie
>         Attachments: YARN-1332.patch
>
>
> TestAMRMClient uses a lot of "assertTrue(amClient.ask.size() == 0)" where 
> "assertEquals(0, amClient.ask.size())" would make it easier to see why it's 
> failing at a glance.



--
This message was sent by Atlassian JIRA
(v6.1#6144)