[ https://issues.apache.org/jira/browse/YARN-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17205449#comment-17205449 ]
Adam Antal commented on YARN-10448: ----------------------------------- Thanks for the patch [~zhuqi]. Would you please include a sample test for the fix? Something like submitting with null user, and assert that the user has been changed to {{default}} successfully. Also could you please move the "default" String to a private static final constant? > SLS should set default user to handle SYNTH format > -------------------------------------------------- > > Key: YARN-10448 > URL: https://issues.apache.org/jira/browse/YARN-10448 > Project: Hadoop YARN > Issue Type: Bug > Components: scheduler-load-simulator > Affects Versions: 3.2.1, 3.4.0 > Reporter: zhuqi > Assignee: zhuqi > Priority: Major > Attachments: YARN-10448.001.patch, YARN-10448.002.patch > > > When using the synthetic generator json file example from the doc ( > https://hadoop.apache.org/docs/current/hadoop-sls/SchedulerLoadSimulator.html#SYNTH_JSON_input_file_format > ), it throws the following exception: > {noformat} > java.lang.IllegalArgumentException: Null user > at > org.apache.hadoop.security.UserGroupInformation.createRemoteUser(UserGroupInformation.java:1269) > at > org.apache.hadoop.security.UserGroupInformation.createRemoteUser(UserGroupInformation.java:1256) > at > org.apache.hadoop.yarn.sls.appmaster.AMSimulator.submitReservationWhenSpecified(AMSimulator.java:191) > at > org.apache.hadoop.yarn.sls.appmaster.AMSimulator.firstStep(AMSimulator.java:161) > at > org.apache.hadoop.yarn.sls.scheduler.TaskRunner$Task.run(TaskRunner.java:88) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > {noformat} > So the solution is either: > 1) to make {{user_name}} a mandatory field, or > 2) to set default user in SLS code if the json file does not define it. > IMO, solution 2 might be better, because in most cases (if not all) > {{user_name}} has no impact on scheduler performance, thus it is reasonable > to make it an optional field, which is also consistent with the {{job.user}} > field in SLS JSON file. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org