[
https://issues.apache.org/jira/browse/YARN-1239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824138#comment-13824138
]
Jian He commented on YARN-1239:
-------------------------------
Thanks [~ozawa] for the reviews.
bq. DUMMY_VERSION_INFO and VERSION_INFO should be initialized as 1L, not 1
bq. These code should pass long value.
Fixed.
bq. We can define strings of error messages as static final in RMStateStore
I think it's fine as that static final field will only be used by test case. I
wanted to assert the exception type instead of exception msg, but turns out
that exception is stringfied and pass into the ExitException.
> Save version information in the state store
> -------------------------------------------
>
> Key: YARN-1239
> URL: https://issues.apache.org/jira/browse/YARN-1239
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Bikas Saha
> Assignee: Jian He
> Attachments: YARN-1239.1.patch, YARN-1239.2.patch, YARN-1239.3.patch,
> YARN-1239.patch
>
>
> When creating root dir for the first time we should write version 1. If root
> dir exists then we should check that the version in the state store matches
> the version from config.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
