[ https://issues.apache.org/jira/browse/YARN-10420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17212411#comment-17212411 ]
Adam Antal commented on YARN-10420: ----------------------------------- Thanks for the patch [~pbacsko]. I'll attach my reply inline. 1. Ok, let's not touch it then. 2. Can we check what happens, and document it as well? I think users would be also interested in that. 3. Can we also add this to the document? 4,5,6. Ok, got it, thanks. bq. "If the target queue doesn't exist or and it cannot be created..." - you propose "and" but that would mean that we always try to create a non-existing queue, which is not the case in CS. Under regular parents, queues cannot be created dynamically and CS doesn't even try. Therefore "or" is more appropriate here. Thanks for the clarification. I suggest to add this to the doc, because I didn't know that "cannot be created" is what you've illustrated as an example. Something like "If the target queue doesn't exist or cannot be created (e.g. under regular parents) ..." For all the other points, I'm fine. > Update CS MappingRule documentation with the new format and features > -------------------------------------------------------------------- > > Key: YARN-10420 > URL: https://issues.apache.org/jira/browse/YARN-10420 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Gergely Pollak > Assignee: Peter Bacsko > Priority: Major > Attachments: YARN-10420-001.patch, YARN-10420-002.patch, > YARN-10420-003.patch, YARN-10420-004.patch, YARN-10420-005.patch > > > Update the upstream documentation with the new changes. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org