[
https://issues.apache.org/jira/browse/YARN-10463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216580#comment-17216580
]
Bilwa S T commented on YARN-10463:
----------------------------------
Hi [~zhuqi]
Thanks for patch. I have few comments:
# In below code you need to call
routerMetrics.incrAppAttemptsFailedRetrieved() instead of
routerMetrics.incrAppsFailedRetrieved();
{code:java}
try {
response = clientRMProxy.getApplicationAttemptReport(request);
} catch (Exception e) {
routerMetrics.incrAppsFailedRetrieved();
LOG.error("Unable to get the applicationAttempt report for "
+ request.getApplicationAttemptId() + "to SubCluster "
+ subClusterId.getId(), e);
throw e;
}
{code}
2. Add null check for Application id ie
request.getApplicationAttemptId().getApplicationId()
3. In TestFederationClientInterceptor.java, change "Test
FederationClientInterceptor: Get Application Report" to "Test
FederationClientInterceptor: Get Application Attempt Report"
4. In testcase instead of Assert.fail() and catch, use
LambdaTestUtils#intercept().
> For Federation, we should support getApplicationAttemptReport.
> --------------------------------------------------------------
>
> Key: YARN-10463
> URL: https://issues.apache.org/jira/browse/YARN-10463
> Project: Hadoop YARN
> Issue Type: Sub-task
> Affects Versions: 3.3.0
> Reporter: zhuqi
> Assignee: zhuqi
> Priority: Major
> Attachments: YARN-10463.001.patch
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
