[ 
https://issues.apache.org/jira/browse/YARN-10471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220982#comment-17220982
 ] 

Eric Payne commented on YARN-10471:
-----------------------------------

I attached version 002 of the patch. This patch addressed the checkstyle and 
findbugs warnings.

The unit tests are not cause by this patch:
- Although one test from {{TestContainersMonitor}}  failed, it was not one of 
the new ones which were added in this patch. 
{{testContainerKillOnExcessLogDirectory}} and 
{{testContainerKillOnExcessTotalLogs}} were the new ones, and they passed. 
{{testContainerKillOnMemoryOverflow}} fails without this patch as well.
- {{TestDeletionService}} is not failing for me.
- {{TestNodeManagerReboot}} fails intermittently even in trunk without this 
patch.
- The rest are also failing in trunk without the patch: 
{{TestContainerLaunch}}, {{TestContainerManager}}, {{TestNodeManagerResync}}, 
{{TestNodeManagerShutdown}}

> Prevent logs for any container from becoming larger than a configurable size.
> -----------------------------------------------------------------------------
>
>                 Key: YARN-10471
>                 URL: https://issues.apache.org/jira/browse/YARN-10471
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 3.2.1, 3.1.4
>            Reporter: Eric Payne
>            Assignee: Eric Payne
>            Priority: Minor
>         Attachments: YARN.10471.001.patch, YARN.10471.002.patch
>
>
> Configure a cluster such that a task attempt will be killed if any container 
> log exceeds a configured size. This would help prevent logs from filling 
> disks and also prevent the need to aggregate enormous logs.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to