[
https://issues.apache.org/jira/browse/YARN-10425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17229206#comment-17229206
]
Gergely Pollak commented on YARN-10425:
---------------------------------------
[~pbacsko] thank you for the feedback.
1) Added some explanation, it is still quite confusing unfortunately, but I'll
try to fix the whole recovery path in an other jira, since there are
conceptional problems there due to legacy reasons.
2) I intentionally did not merge those conditions, since it's already quite
confusing, also I find it more clear to have a dedicated recovery branch, and
the other condition is only a step on that branch (currently the only one)
3) ret represents return value, I think it's quite expressive, since the
function's name and description already define what kind of data we store there
it's more important to let the reader know, we are setting the return value,
not just some random applicationPlacementContext, which might get returned
later. Using ret explicitly lets us know, we are changing the return value.
4) Checkstyle warnings lost, so uploaded a patch to regenerate them, fixing
those in the next iteration.
> Replace the legacy placement engine in CS with the new one
> ----------------------------------------------------------
>
> Key: YARN-10425
> URL: https://issues.apache.org/jira/browse/YARN-10425
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Gergely Pollak
> Assignee: Gergely Pollak
> Priority: Major
> Attachments: YARN-10425.001.patch, YARN-10425.002.patch,
> YARN-10425.003.patch, YARN-10425.004.patch, YARN-10425.005.patch,
> YARN-10425.006.patch
>
>
> Remove the UserGroupMapping and ApplicationName mapping classes, and use the
> new CSMappingPlacementRule instead. Also cleanup the orphan classes which are
> used by these classes only.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
