[
https://issues.apache.org/jira/browse/YARN-10425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17229219#comment-17229219
]
Peter Bacsko edited comment on YARN-10425 at 11/10/20, 1:41 PM:
----------------------------------------------------------------
"ret represents return value, I think it's quite expressive, since the
function's name and description already define what kind of data we store there
it's more important to let the reader know, we are setting the return value"
Did some research on this before posting, turns out there are people who indeed
use "ret". I'd still be more comfortable with a name like "result", though
(https://softwareengineering.stackexchange.com/questions/134321/is-it-a-good-practice-to-name-the-returned-variable-result)
"_There are only two hard things in Computer Science: cache invalidation and_
_naming things.__”_
was (Author: pbacsko):
"ret represents return value, I think it's quite expressive, since the
function's name and description already define what kind of data we store there
it's more important to let the reader know, we are setting the return value"
Did some research on this before posting, turns out there are people who indeed
use "ret". I'd still be more comfortable with a name like "result", though.
"_There are only two hard things in Computer Science: cache invalidation and_
_naming things.__”_
> Replace the legacy placement engine in CS with the new one
> ----------------------------------------------------------
>
> Key: YARN-10425
> URL: https://issues.apache.org/jira/browse/YARN-10425
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Gergely Pollak
> Assignee: Gergely Pollak
> Priority: Major
> Attachments: YARN-10425.001.patch, YARN-10425.002.patch,
> YARN-10425.003.patch, YARN-10425.004.patch, YARN-10425.005.patch,
> YARN-10425.006.patch
>
>
> Remove the UserGroupMapping and ApplicationName mapping classes, and use the
> new CSMappingPlacementRule instead. Also cleanup the orphan classes which are
> used by these classes only.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
