[
https://issues.apache.org/jira/browse/YARN-10490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238218#comment-17238218
]
Andras Gyori commented on YARN-10490:
-------------------------------------
Thank you [~akshink] for the patch. I like the idea of adding a shutdown hook
and the overall logic seems good to me. I would advise some enhancement to
improve the readability:
* Extract the hook in a static method and pass it to the thread
(this::shutDownHook)
* Extract the clearing constant *\033[H\033[2J* in a constant variable (this
is quite cryptic if someone is not familiar with the unix ANSI clear sequence)
> "yarn top" command not quiting completely with ctrl+c
> -----------------------------------------------------
>
> Key: YARN-10490
> URL: https://issues.apache.org/jira/browse/YARN-10490
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: yarn
> Reporter: Agshin Kazimli
> Assignee: Agshin Kazimli
> Priority: Minor
> Attachments: YARN-10490-001.patch, YARN-10490-001.patch
>
>
> When we quit "yarn top" command using ctrl+c, even though the command prompt
> returns, the old statistics info is still visible below the prompt.
> And we need to manually type clear command or multiple return keys to get
> around it. It is reported as a inconvenience for the customer from a
> usability perspective.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
