[
https://issues.apache.org/jira/browse/YARN-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241375#comment-17241375
]
Agshin Kazimli commented on YARN-7200:
--------------------------------------
[~gandras] Thank you for the review. In an ideal setup, the
service(SLSFairScheduler or SLSCapacity Scheduler) should have been stoped and
this would call schedulerMetrics#tearDown method, which in turn writes and
closes the buffer. It seems that, the SLSFairScheduler(SLSCapacityScheduler)
never stops(because, there is always event coming up even after all the
applications are closed), therefore old exit logic was to force the application
to exit right after all the applications are succeded. In this case, when the
tearDown method is invoked in the SchedulerEvent handler method, it means
scheduler is not stopped yet, it can perform the action. After that, we can
safely force the application to quit.
> SLS generates a realtimetrack.json file but that file is missing the closing
> ']'
> --------------------------------------------------------------------------------
>
> Key: YARN-7200
> URL: https://issues.apache.org/jira/browse/YARN-7200
> Project: Hadoop YARN
> Issue Type: Bug
> Components: scheduler-load-simulator
> Reporter: Grant Sohn
> Assignee: Agshin Kazimli
> Priority: Minor
> Labels: newbie, newbie++
> Attachments: YARN-7200-branch-trunk.patch, YARN-7200.002.patch,
> snemeth-testing-20201113.zip
>
>
> File
> hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/scheduler/SchedulerMetrics.java
> shows:
> {noformat}
> void tearDown() throws Exception {
> if (metricsLogBW != null) {
> metricsLogBW.write("]");
> metricsLogBW.close();
> }
> ....
> {noformat}
> So the exit logic is flawed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
