[
https://issues.apache.org/jira/browse/YARN-10527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
shilongfei updated YARN-10527:
------------------------------
Description:
Reading hadoop metric related code recently, MetricsSystemImpl confused me, as
follows:
1. MS_INIT_MODE_KEY never seems to be set, so the initMode() will always return
NORMAL, MetricsSystemImpl will be launched when RM was standby state. In
addition, MS_INIT_MODE_KEY is very inconvenient to use.
2. Assuming the first problem does not exist, MetricsSystemImpl is not launched
when RM was standby state. When RM goes from standby to active, init() method
will not be called again, MetricsSystemImpl will never be started.
3. init() and start() are not equivalent, so whose behavior should be record by
refCount?
> MetricsSystemImpl#init semantics seem somewhat ambiguous
> --------------------------------------------------------
>
> Key: YARN-10527
> URL: https://issues.apache.org/jira/browse/YARN-10527
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: shilongfei
> Priority: Major
>
> Reading hadoop metric related code recently, MetricsSystemImpl confused me,
> as follows:
> 1. MS_INIT_MODE_KEY never seems to be set, so the initMode() will always
> return NORMAL, MetricsSystemImpl will be launched when RM was standby state.
> In addition, MS_INIT_MODE_KEY is very inconvenient to use.
> 2. Assuming the first problem does not exist, MetricsSystemImpl is not
> launched when RM was standby state. When RM goes from standby to active,
> init() method will not be called again, MetricsSystemImpl will never be
> started.
> 3. init() and start() are not equivalent, so whose behavior should be record
> by refCount?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
