[ https://issues.apache.org/jira/browse/YARN-4457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17251874#comment-17251874 ]
Kihwal Lee commented on YARN-4457: ---------------------------------- [~rkanter], we were trying to build branch-3.3 and saw some failure related to the commit. When we do {{mvn versions:set -DnewVersion=xxxxx}}, the build fails with a parse error in the hadoop project pom. {noformat} [ERROR] Failed to execute goal org.codehaus.mojo:versions-maven-plugin:2.8.1:set (default-cli) on project hadoop-main: Execution default-cli of goal org.codehaus.mojo:versions-maven-plugin:2.8.1:set failed: Error parsing /Users/kihwal/devel/y2/Hadoop/hadoop-project/pom.xml: Unexpected character '-' (code 45) (expected a name start character) [ERROR] at [row,col {unknown-source}]: [2247,12] {noformat} The corresponding line was added by this commit. But the version 6 patch doesn't have this. Was it a mistake? {code:xml} diff --git a/hadoop-project/pom.xml b/hadoop-project/pom.xml index 1ae60ed8d4b..336231e8226 100644 --- a/hadoop-project/pom.xml +++ b/hadoop-project/pom.xml @@ -1570,6 +1570,7 @@ <target>${javac.version}</target> <compilerArguments> <Xlint/> + <Xlint:-unchecked/> <Xmaxwarns>9999</Xmaxwarns> </compilerArguments> </configuration> {code} > Cleanup unchecked types for EventHandler > ---------------------------------------- > > Key: YARN-4457 > URL: https://issues.apache.org/jira/browse/YARN-4457 > Project: Hadoop YARN > Issue Type: Improvement > Affects Versions: 2.7.1 > Reporter: Daniel Templeton > Assignee: Daniel Templeton > Priority: Major > Labels: oct16-easy > Fix For: 3.0.0-alpha2 > > Attachments: YARN-4457.001.patch, YARN-4457.002.patch, > YARN-4457.003.patch, YARN-4457.004.patch, YARN-4457.005.patch, > YARN-4457.006.patch > > > The EventHandler class is often used in an untyped context resulting in a > bunch of warnings about unchecked usage. The culprit is the > {{Dispatcher.getHandler()}} method. Fixing the typing on the method to > return {{EventHandler<Event>}} instead of {{EventHandler}} clears up the > errors and doesn't not introduce any incompatible changes. In the case that > some code does: > {code} > EventHandler h = dispatcher.getHandler(); > {code} > it will still work and will issue a compiler warning about raw types. There > are, however, no instances of this issue in the current source base. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org