[ 
https://issues.apache.org/jira/browse/YARN-786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826914#comment-13826914
 ] 

Jason Lowe commented on YARN-786:
---------------------------------

+1 for the addendum patch, looks pretty good.  Couple of nits but not must-fix 
before commit:

- I'd expect the lack of a scheduler app report to be a relatively common case, 
so it would be nice to have a pre-built zero resource usage report similar to 
the DUMMY_APPLICATION_RESOURCE_USAGE_REPORT used by RMAppImpl when someone 
doesn't have access.
- It would be nice to have a test case.  There was a similar 
check-for-null-report testcase in TestRMAppTransitions#testGetAppReport, but it 
only tested an app in the NEW state and didn't catch this.

> Expose application resource usage in RM REST API
> ------------------------------------------------
>
>                 Key: YARN-786
>                 URL: https://issues.apache.org/jira/browse/YARN-786
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.0.4-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>             Fix For: 2.3.0
>
>         Attachments: YARN-786-1.patch, YARN-786-2.patch, 
> YARN-786-addendum.patch, YARN-786.patch
>
>
> It might be good to require users to explicitly ask for this information, as 
> it's a little more expensive to collect than the other fields in AppInfo.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to