[
https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17265149#comment-17265149
]
Wangda Tan commented on YARN-10506:
-----------------------------------
[~pbacsko], I see, I think it makes sense.
{quote}The logic must be there, otherwise we can't proceed to the next rule if
the fallback is set to "skip". If you perform the validations (which are
currently done by {{CSMappingPlacementRule}}) outside of the placement engine,
you lose the ability to execute different actions (skip/reject/place to
default).
{quote}
Because it is different from the previous CS queue mapping: previously, when a
rule matches, it up to the scheduler to make a decision such as create queue,
accept or reject the app.
Now we need to make sure rule engine makes the right decision before sending
the request to scheduler. We need to be careful about possible racing
conditions. But I think you're right, when admin change
<queue>.auto-queue-creation-v2.enabled in the queue hierarchy, it is possible
to cause undesirable result. But syncing between the two systems (rule engine
and scheduler) will have delays in any case, so removing create flag from
ApplicationPlacementContext sounds not bad.
I will let [~zhuqi], [~gandras] and you guys to decide what is the best
approach to take, I'm OK with either approaches. But let's reach a conclusion
fast since this patch blocks a number of follow up tickets.
> Update queue creation logic to use weight mode and allow the flexible
> static/dynamic creation
> ---------------------------------------------------------------------------------------------
>
> Key: YARN-10506
> URL: https://issues.apache.org/jira/browse/YARN-10506
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Benjamin Teke
> Assignee: Andras Gyori
> Priority: Major
> Attachments: YARN-10506-006-10504-010.patch,
> YARN-10506-007-10504-010.patch, YARN-10506-008.patch, YARN-10506-010.patch,
> YARN-10506-012.patch, YARN-10506.001.patch, YARN-10506.002.patch,
> YARN-10506.003.patch, YARN-10506.004.patch, YARN-10506.005.patch,
> YARN-10506.006-combined.patch, YARN-10506.006.patch, YARN-10506.007.patch,
> YARN-10506.009.patch, YARN-10506.011.patch
>
>
> The queue creation logic should be updated to use weight mode and support the
> flexible creation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
