[ https://issues.apache.org/jira/browse/YARN-10573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17267512#comment-17267512 ]
Szilard Nemeth commented on YARN-10573: --------------------------------------- Hi [~pbacsko], Just spotted one thing in QueuePlacementConverter: {code:java} if (fsParentCreate ^ create) { {code} Is this intentionally bitwise-OR? Otherwise, the latest patch LGTM. > Enhance placement rule conversion in fs2cs in weight mode and enable it by > default > ---------------------------------------------------------------------------------- > > Key: YARN-10573 > URL: https://issues.apache.org/jira/browse/YARN-10573 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Peter Bacsko > Assignee: Peter Bacsko > Priority: Major > Labels: fs2cs > Attachments: YARN-10573-001.patch, YARN-10573-002.patch, > YARN-10573-003.patch > > > If we're using weight mode, we have much more freedom when it comes to > placement rules. > We need to do three things in this ticket: > #1 > In YARN-10525, weight conversion became the default in {{fs2cs}}. This also > means that we can support nested rules properly and also queues can be > created under {{root}}. > Therefore, a lot of warnings and validations inside > {{QueuePlacementConverter}} are not necessary and only relevant if the user > chose percentage-based conversion in the command line. > #2 > Remove unnecessary stuff in the RuleHandler which are already supported (plus > the test code which affected by this): > * SPECIFIED_NOT_FIRST > * USER_MAX_APPS_DEFAULT > * USER_MAX_RUNNING_APPS > #3 > Currently, users have to use "\-m" or "\-\-convert\-placement\-rules" switch > to convert the placement rules from FS. > Initially, we converted to the old mapping rule format, which has serious > limitations, so we disabled the automatic conversion. > With the new JSON-based format and placement engine, this conversion should > happen automatically. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org