[ 
https://issues.apache.org/jira/browse/YARN-10578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17267879#comment-17267879
 ] 

Andras Gyori commented on YARN-10578:
-------------------------------------

Thank you [~shuzirra], it is a valid point! However, I think this lock is there 
to make sure the CS is intact while creating the queue, so that no additional 
queue handling is made during the period of auto queue creation. The 
CSAutoQueueCreationHandler itself does not contain any state apart from the 
queueManager, which is thread safe internally. 

> Fix Auto Queue Creation parent handling
> ---------------------------------------
>
>                 Key: YARN-10578
>                 URL: https://issues.apache.org/jira/browse/YARN-10578
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacity scheduler
>            Reporter: Andras Gyori
>            Assignee: Andras Gyori
>            Priority: Major
>         Attachments: YARN-10578.001.patch, YARN-10578.002.patch
>
>
> YARN-10506 introduced the new auto queue creation logic, however a parent == 
> null check in CapacityScheduler#autoCreateLeafQueue will prevent a two levels 
> queue to be created. We need to revert it back to the normal logic, also, we 
> should wrap the auto queue handling with a lock.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to