[jira] [Comment Edited] (YARN-10512) CS Flexible Auto Queue Creation: Modify RM /scheduler endpoint to include mode of operation for CS

[Peter Bacsko (Jira)]

    [ 
https://issues.apache.org/jira/browse/YARN-10512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17267894#comment-17267894
 ] 

Peter Bacsko edited comment on YARN-10512 at 1/19/21, 1:51 PM:
---------------------------------------------------------------

I just have very minor nits:

#1
{noformat}
config.set(YarnConfiguration.SCHEDULER_CONFIGURATION_STORE_CLASS,
                YarnConfiguration.MEMORY_CONFIGURATION_STORE);
{noformat}
This call is repeated multiple times, this could be set somewhere else.

 

#2
{noformat}
validateSchedulerInfo(json, "weight", "root.default", "root.test1", 
"root.test2");
{noformat}
"root.default", "root.test1" and "root.test2" are the same in all cases, you 
might want to drop them

 

#3
{noformat}
          @Before
          @Override
          public void setUp() throws Exception {
            super.setUp();
          }
{noformat}
This method does nothing, can be removed.
  


was (Author: pbacsko):
I just have very minor nits:
{noformat}
config.set(YarnConfiguration.SCHEDULER_CONFIGURATION_STORE_CLASS,
                YarnConfiguration.MEMORY_CONFIGURATION_STORE);
{noformat}
This call is repeated multiple times, this could be set somewhere else.
{noformat}
validateSchedulerInfo(json, "weight", "root.default", "root.test1", 
"root.test2");
{noformat}
"root.default", "root.test1" and "root.test2" are the same in all cases, you 
might want to drop them
{noformat}
      @Before
          @Override
          public void setUp() throws Exception {
            super.setUp();
          }
{noformat}
This method does nothing, can be removed.
  

> CS Flexible Auto Queue Creation: Modify RM /scheduler endpoint to include 
> mode of operation for CS
> --------------------------------------------------------------------------------------------------
>
>                 Key: YARN-10512
>                 URL: https://issues.apache.org/jira/browse/YARN-10512
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Benjamin Teke
>            Assignee: Szilard Nemeth
>            Priority: Major
>         Attachments: YARN-10512.001.patch, YARN-10512.002.patch, 
> YARN-10512.003.patch, YARN-10512.004.patch
>
>
> Under this umbrella (YARN-10496), weight-mode has been implemented for CS 
> with YARN-10504.
> We would like to expose the mode of operation with the RM's /scheduler REST 
> endpoint.
> The field name will be 'mode'.
> All queue representations in the response will be uniformly hold any of the 
> mode values of: "percentage", "absolute", "weight".



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org