[ https://issues.apache.org/jira/browse/YARN-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17268755#comment-17268755 ]
Wangda Tan commented on YARN-10531: ----------------------------------- Thanks [~zhuqi], Two minor comments: 1) ParentQueue.java: - We can remove: FIXME: Ideally we should disable user limit factor, see YARN-10531 2) AbstractCSQueue: Nit: Let's breakdown {code} 1542 int maxApplicationsPerUser = 1543 leafQueue.getUsersManager().getUserLimitFactor() != -1 1544 ? Math.min(maxApplications, 1545 (int) (maxApplications 1546 * (leafQueue.getUsersManager().getUserLimit() / 100.0f) 1547 * leafQueue.getUsersManager().getUserLimitFactor())) 1548 : maxApplications; {code} Into multiple statements for better readability. Thoughts? [~sunilg], [~shuzirra], [~snemeth], [~pbacsko] > Be able to disable user limit factor for CapacityScheduler Leaf Queue > --------------------------------------------------------------------- > > Key: YARN-10531 > URL: https://issues.apache.org/jira/browse/YARN-10531 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Wangda Tan > Assignee: zhuqi > Priority: Major > Attachments: YARN-10531.001.patch, YARN-10531.002.patch, > YARN-10531.003.patch, YARN-10531.004.patch, YARN-10531.005.patch > > > User limit factor is used to define max cap of how much resource can be > consumed by single user. > Under Auto Queue Creation context, it doesn't make much sense to set user > limit factor, because initially every queue will set weight to 1.0, we want > user can consume more resource if possible. It is hard to pre-determine how > to set up user limit factor. So it makes more sense to add a new value (like > -1) to indicate we will disable user limit factor > Logic need to be changed is below: > (Inside LeafQueue.java) > {code} > Resource maxUserLimit = Resources.none(); > if (schedulingMode == SchedulingMode.RESPECT_PARTITION_EXCLUSIVITY) { > maxUserLimit = Resources.multiplyAndRoundDown(queueCapacity, > getUserLimitFactor()); > } else if (schedulingMode == SchedulingMode.IGNORE_PARTITION_EXCLUSIVITY) > { > maxUserLimit = partitionResource; > } > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org