[
https://issues.apache.org/jira/browse/YARN-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13828094#comment-13828094
]
Mayank Bansal commented on YARN-1266:
-------------------------------------
Thanks [~vinodkv] and [~zjshen] for the review.
bq. 1. Let's mark getApplicationReport/getApplications stable, though they are
moved to base protocol. How do you think?
Done
bq. 2. In ApplicationBaseProtocol, please do not mention history sever.
It contains both RM and AHS which is correct
bq. 3. Where's ApplicationBaseProtocolPBClientImpl?
bq. 4. Should you modify ApplicationClientProtocolPBClientImpl as well?
bq. 5. ApplicationHistoryProtocolPBClientImpl should extend
ApplicationBaseProtocolPBClientImpl.
We discussed offline and we are planning not to add that.
bq. I hope this is a compatible change - moving methods to a super-interface.
Can you please check?
Yes these are compatible changes.
bq.Mark application_base_protocol.proto and ApplicationBaseProtocol as some
kind of internal interfaces not to be used directly? May be by making them only
package private and protected or something. Along with that we'll need to put
correct audience and visibility annotations.
bq. Similarly for the client and service wrappers.
Done
> inheriting Application client and History Protocol from base protocol and
> implement PB service and clients.
> -----------------------------------------------------------------------------------------------------------
>
> Key: YARN-1266
> URL: https://issues.apache.org/jira/browse/YARN-1266
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Mayank Bansal
> Assignee: Mayank Bansal
> Attachments: YARN-1266-1.patch, YARN-1266-2.patch, YARN-1266-3.patch,
> YARN-1266-4.patch, YARN-1266-5.patch
>
>
> Adding ApplicationHistoryProtocolPBService to make web apps to work and
> changing yarn to run AHS as a seprate process
--
This message was sent by Atlassian JIRA
(v6.1#6144)
