[
https://issues.apache.org/jira/browse/YARN-10598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272939#comment-17272939
]
Szilard Nemeth commented on YARN-10598:
---------------------------------------
Hi [~bteke],
Latest patch looks good to me.
Two minor things only:
# This method is not used:
org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesCapacitySchedDynamicConfig#submitApp
# It would be useful to add javadoc for all static final variables that are
among valid values of autoCreationType, queueType and auto creation
eligibility:
org.apache.hadoop.yarn.server.resourcemanager.webapp.dao.helper.CapacitySchedulerInfoHelper
I can also accept this in a follow-up fix as it's not critical.
> CS Flexible Auto Queue Creation: Modify RM /scheduler endpoint to extend the
> creation type with additional information
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: YARN-10598
> URL: https://issues.apache.org/jira/browse/YARN-10598
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Benjamin Teke
> Assignee: Benjamin Teke
> Priority: Major
> Attachments: YARN-10598.001.patch, YARN-10598.002.patch
>
>
> Under this umbrella (YARN-10496), weight-mode has been implemented for CS
> with YARN-10504.
> Auto-queue creation has been also implemented with YARN-10506.
> Connected to this effort, we would like to expose the type of the queue with
> the RM's /scheduler REST endpoint.
> To extend/modify the values added in YARN-10581 these 3 fields will describe
> a queue:
> * queueType : *parent/leaf*
> * creationMethod : *static/dynamicLegacy/dynamicFlexible*
> * autoCreationEligibility : *off/legacy/flexible*
> After this change here are some example cases:
> * Static parent queue which has the auto-creation-enabled-v2 false:
> ** queueType : *parent*
> ** creationMethod : *static*
> ** autoCreationEligibility : *off*
> * Static managed parent (can have dynamic children):
> ** queueType : *parent*
> ** creationMethod : *static*
> ** autoCreationEligibility : *legacy*
> * Legacy auto-created leaf queue (cannot have children):
> ** queueType : *leaf*
> ** creationMethod : *dynamicLegacy*
> ** autoCreationEligibility : *off*
> * Auto-created (v2) parent queue, (implicitly) auto-creation-enabled-v2
> true:
> ** queueType : *parent*
> ** creationMethod : *dynamicFlexible*
> ** autoCreationEligibility : *flexible*
> * Auto-created (v2) leaf queue (cannot have children):
> ** queueType : *leaf*
> ** creationMethod : *dynamicFlexible*
> ** autoCreationEligibility : *off*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
