[
https://issues.apache.org/jira/browse/YARN-10590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274178#comment-17274178
]
zhuqi commented on YARN-10590:
------------------------------
Thanks [~bteke] for review.
"Because as we discussed in YARN-10504 , the initialization of auto created
queues from template was changed (see comment and comment)."
1. As the comment we discussed, we found the effective core is different(the
gap), because the update effective will override the absolute auto created
leaf queue.
2. But actually, the override is right, the difference is caused by test case ,
don't consider the caculation loss of multi resource type, the cap/absolute are
all caculated by one type, (memory) in default resourcecaculator, (dominant
type) in dominant resourcecaculator. As we known in the comment, the absolute
auto created leaf queue will merge the effective resource by cap/absolute
caculated result, this caused the gap.
2. In other case(not absolute case) in the auto created leaf queue, the merge
will not cause the gap, in update effective resource override will also use the
one type caculated result.
3. So this jira just make the test right, the caculation result is already
right.
In future we should make multi type caculation of cap/absolute, consistent with
the absolute multi resource type.
In Jira : YARN-10592
I introduced the vector of cap/absolute, it will make this consistent . Also in
the future, we will handle other cases about multi resource type cases, it is
a more huge thing to do, may be we need a new Umbrella to forward this.
cc [~wangda] if you any thoughts about this and YARN-10592.
Thanks.
> Fix TestCapacitySchedulerAutoCreatedQueueBase witch related absolute
> caculation loss.
> -------------------------------------------------------------------------------------
>
> Key: YARN-10590
> URL: https://issues.apache.org/jira/browse/YARN-10590
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: zhuqi
> Assignee: zhuqi
> Priority: Major
> Attachments: YARN-10590.001.patch, YARN-10590.002.patch
>
>
> Because we have introduced YARN-10504.
> In auto created leaf queue with absolute mode, the caculation of effective
> min resource will different from other mode.
> We should fix the related test in TestCapacitySchedulerAutoCreatedQueueBase.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
