[ 
https://issues.apache.org/jira/browse/YARN-10589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17276992#comment-17276992
 ] 

Qi Zhu commented on YARN-10589:
-------------------------------

[~ztang] [~tanu.ajmera]

I attached a new patch 003  based 002 , i think return PARTITION_SKIPPED will 
return and get next PRIORITY_SKIPPED in :
{code:java}
while (iter.hasNext()) {
  FiCaSchedulerNode node = iter.next();

  if (reservedContainer == null) {
    result = preCheckForNodeCandidateSet(clusterResource, node,
        schedulingMode, resourceLimits, schedulerKey);
    if (null != result) {
      if (result == ContainerAllocation.PARTITION_SKIPPED) {
        return result;
      } else {
        continue;
      }
    }
  }
{code}
Thanks.

> Improve logic of multi-node allocation
> --------------------------------------
>
>                 Key: YARN-10589
>                 URL: https://issues.apache.org/jira/browse/YARN-10589
>             Project: Hadoop YARN
>          Issue Type: Task
>    Affects Versions: 3.3.0
>            Reporter: Tanu Ajmera
>            Assignee: Tanu Ajmera
>            Priority: Major
>         Attachments: YARN-10589-001.patch, YARN-10589-002.patch, 
> YARN-10589-003.patch
>
>
> {code:java}
> for (String partititon : partitions) {
>  if (current++ > start) {
>  break;
>  }
>  CandidateNodeSet<FiCaSchedulerNode> candidates =
>  cs.getCandidateNodeSet(partititon);
>  if (candidates == null) {
>  continue;
>  }
>  cs.allocateContainersToNode(candidates, false);
> }{code}
> In above logic, if we have thousands of node in one partition, we will still 
> repeatedly access all nodes of the partition thousands of times. There is no 
> break point where if the partition is not same for the first node, it should 
> stop checking other nodes in that partition.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to