[
https://issues.apache.org/jira/browse/YARN-10547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277859#comment-17277859
]
Andras Gyori commented on YARN-10547:
-------------------------------------
Thank you [~snemeth] for the patch. As this is a refactor task, I have not done
deep semantic analysis, also due to my lack of SLS exposure it would mean a
greater ramp-up to gain some proficiency in the subject. However, I have
collected some feedback nonetheless:
* AMDefinition has a Builder, which is not a standard fluent API based
Builder. Is this intentional?
* AMDefinitionFactory should be final
* There are numerous raw type scattered in different classes (this could be
mitigated by saying Map<?, ?> if the type is unknown)
** AMDefinitionFactory
** AMDefinitionSLS
** TaskContainerDefinition
It looks much cleaner to me, good job on this. +1 if these concerns are
addressed along with the checkstyle errors.
> Decouple job parsing logic from SLSRunner
> -----------------------------------------
>
> Key: YARN-10547
> URL: https://issues.apache.org/jira/browse/YARN-10547
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Minor
> Attachments: YARN-10547.001.patch, YARN-10547.002.patch,
> YARN-10547.003.patch
>
>
> SLSRunner has too many responsibilities.
> One of them is to parse the job details from the SLS input formats and launch
> the AMs and task containers.
> As a first step, the job parser logic could be decoupled from this class.
> There are 3 types of inputs:
> - SLS trace
> - Synth
> - Rumen
> Their job parsing method are:
> - SLS trace:
> https://github.com/apache/hadoop/blob/005b854f6bad66defafae0abf95dabc6c36ca8b1/hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/SLSRunner.java#L479-L526
> - Synth:
> https://github.com/apache/hadoop/blob/005b854f6bad66defafae0abf95dabc6c36ca8b1/hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/SLSRunner.java#L722-L790
> - Rumen:
> https://github.com/apache/hadoop/blob/005b854f6bad66defafae0abf95dabc6c36ca8b1/hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/SLSRunner.java#L651-L716
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
