[
https://issues.apache.org/jira/browse/YARN-10585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17278337#comment-17278337
]
Szilard Nemeth edited comment on YARN-10585 at 2/3/21, 8:08 PM:
----------------------------------------------------------------
Hi [~ahussein],
My thoughts:
1. Apologies for merging this one with the Findbugs issue.
I have been a committer since middle of 2019 and have been paying attention and
have been striving for the best code quality and Yetus results, making sure the
code meets the code quality standards we're expecting at Hadoop.
This one is an exceptional case that simply fell through the cracks.
2. About the UT failures: They are completely unrelated
-
org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart.testRMRestartOnMissingAttempts[FAIR]:
This is Fair scheduler related and the patch is not
-
org.apache.hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer.testRMRestartWithExpiredToken:
This is a well known flakey.
3. I can see that [~shuzirra] already reported YARN-10612 and you also left a
comment there.
I still don't understand how reopening this jira is a better approach than
fixing it in a follow-up.
We will have one more commit on top of trunk nevertheless, as I would not
revert this commit for the sake of a single findbugs warning.
You mentioned amending on the other jira. How did you mean that? I never
amended any commit as it modifies git's commit history and this is to be
avoided on a repository that is used by many many people.
4. About scalability: I generally agree with your comment but as said in bullet
point 1, this is an excecptional situation. I have 200+ commits and I can't
recall a case where I committed findbugs issues. So it's a bit of an
overstatement that this will cause a flood of commits.
5. Credibility: I can agree that we need to strive for findbugs error free
commits. However, I have carefully reviewed the unit tests Gergo introduced and
the coverage was more than enough. Such an NPE would have surfaced during the
UT execution as well.
was (Author: snemeth):
Hi [~ahussein],
My thoughts:
1. Apologies for merging this one with the Findbugs issue.
I have been a committer since middle of 2019 and have been paying attention and
have been striving for the best code quality and Yetus results, making sure the
code meets the code quality standards we're expecting at Hadoop.
This one is an exceptional case that simply fell through the cracks.
2. About the UT failures: They are completely unrelated
-
org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart.testRMRestartOnMissingAttempts[FAIR]:
This is Fair scheduler related and the patch is not
-
org.apache.hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer.testRMRestartWithExpiredToken:
This is a well known flakey.
3. I can see that [~shuzirra] already reported YARN-10612 and you also left a
comment there.
I still don't understand how reopening this jira is a better approach than
fixing it in a follow-up.
We will have one more commit on top of trunk nevertheless, as I would not
revert this commit for the sake of a single findbugs warning.
You mentioned amending on the other jira. How did you mean that? I never
amended any commit as it modified git history and this is to be avoided on a
repository that is used by many many people.
4. About scalability: I generally agree with your comment but as said in bullet
point 1, this is an excecptional situation. I have 200+ commits and I can't
recall a case where I committed findbugs issues. So it's a bit of an
overstatement that this will cause a flood of commits.
5. Credibility: I can agree that we need to strive for findbugs error free
commits. However, I have carefully reviewed the unit tests Gergo introduced and
the coverage was more than enough. Such an NPE would have surfaced during the
UT execution as well.
> Create a class which can convert from legacy mapping rule format to the new
> JSON format
> ---------------------------------------------------------------------------------------
>
> Key: YARN-10585
> URL: https://issues.apache.org/jira/browse/YARN-10585
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Gergely Pollak
> Assignee: Gergely Pollak
> Priority: Major
> Fix For: 3.4.0
>
> Attachments: YARN-10585.001.patch, YARN-10585.002.patch,
> YARN-10585.003.patch
>
>
> To make transition easier we need to create tooling to support the migration
> effort. The first step is to create a class which can migrate from legacy to
> the new JSON format.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
