[
https://issues.apache.org/jira/browse/YARN-10612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17278453#comment-17278453
]
Gergely Pollak edited comment on YARN-10612 at 2/4/21, 1:25 AM:
----------------------------------------------------------------
Trunk compile shows the findbugs error, patch compile doesn't so I think we can
consider it fixed. The reason we don't have any tests for this change is the
actual findbugs warning was caused by an unnecessary null check, and null
inputs already have test cases.
Console log relevant part:
{code:java}
============================================================================
============================================================================
findbugs detection: patch
============================================================================
============================================================================
...
Writing
/home/jenkins/jenkins-agent/workspace/PreCommit-YARN-Build/out/combined-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.xmlhadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
{code}
was (Author: shuzirra):
Trunk compile shows the findbugs error, patch compile doesn't so I think we can
consider it fixed. The reason we don't have any tests for this change is the
actual findbugs warning was caused by an unnecessary null check, and null
inputs already have test cases.
> Fix find bugs issue introduced in YARN-10585
> --------------------------------------------
>
> Key: YARN-10612
> URL: https://issues.apache.org/jira/browse/YARN-10612
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Gergely Pollak
> Assignee: Gergely Pollak
> Priority: Major
> Attachments: YARN-10612.001.patch
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
