[ 
https://issues.apache.org/jira/browse/YARN-10627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291001#comment-17291001
 ] 

Hadoop QA commented on YARN-10627:
----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime ||  Logfile || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  1m 
58s{color} | {color:blue}{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} || ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  
0s{color} | {color:green}{color} | {color:green} No case conflicting files 
found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green}{color} | {color:green} The patch does not contain any 
@author tags. {color} |
| {color:green}+1{color} | {color:green} {color} | {color:green}  0m  0s{color} 
| {color:green}test4tests{color} | {color:green} The patch appears to include 1 
new or modified test files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} || ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 26m 
31s{color} | {color:green}{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
12s{color} | {color:green}{color} | {color:green} trunk passed with JDK 
Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
5s{color} | {color:green}{color} | {color:green} trunk passed with JDK Private 
Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
 3s{color} | {color:green}{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m  
8s{color} | {color:green}{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
19m 14s{color} | {color:green}{color} | {color:green} branch has no errors when 
building and testing our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
45s{color} | {color:green}{color} | {color:green} trunk passed with JDK 
Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
40s{color} | {color:green}{color} | {color:green} trunk passed with JDK Private 
Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue}  2m 
30s{color} | {color:blue}{color} | {color:blue} Used deprecated FindBugs 
config; considering switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
28s{color} | {color:green}{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} || ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
57s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
7s{color} | {color:green}{color} | {color:green} the patch passed with JDK 
Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  
7s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
52s{color} | {color:green}{color} | {color:green} the patch passed with JDK 
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
52s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  
0m 49s{color} | 
{color:orange}https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/677/artifact/out/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt{color}
 | {color:orange} 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:
 The patch generated 2 new + 146 unchanged - 16 fixed = 148 total (was 162) 
{color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
58s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green}{color} | {color:green} The patch has no whitespace 
issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
16m 56s{color} | {color:green}{color} | {color:green} patch has no errors when 
building and testing our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
49s{color} | {color:green}{color} | {color:green} the patch passed with JDK 
Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
37s{color} | {color:green}{color} | {color:green} the patch passed with JDK 
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
11s{color} | {color:green}{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} || ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}104m 10s{color} 
| 
{color:red}https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/677/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt{color}
 | {color:red} hadoop-yarn-server-resourcemanager in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
34s{color} | {color:green}{color} | {color:green} The patch does not generate 
ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}186m  4s{color} | 
{color:black}{color} | {color:black}{color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | 
hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerSurgicalPreemption
 |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/677/artifact/out/Dockerfile
 |
| JIRA Issue | YARN-10627 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/13021210/YARN-10627.004.patch |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite 
unit shadedclient findbugs checkstyle |
| uname | Linux a71cb656645a 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 
18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / a89c624002f |
| Default Java | Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| Multi-JDK versions | 
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 
/usr/lib/jvm/java-8-openjdk-amd64:Private 
Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
|  Test Results | 
https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/677/testReport/ |
| Max. process+thread count | 823 (vs. ulimit of 5500) |
| modules | C: 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
 U: 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
 |
| Console output | 
https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/677/console |
| versions | git=2.25.1 maven=3.6.3 findbugs=4.0.6 |
| Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org |


This message was automatically generated.



> Extend logging to give more information about weight mode
> ---------------------------------------------------------
>
>                 Key: YARN-10627
>                 URL: https://issues.apache.org/jira/browse/YARN-10627
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: yarn
>            Reporter: Benjamin Teke
>            Assignee: Benjamin Teke
>            Priority: Major
>         Attachments: YARN-10627.001.patch, YARN-10627.002.patch, 
> YARN-10627.003.patch, YARN-10627.004.patch, YARN-10627.005.patch, 
> image-2021-02-20-00-07-09-875.png
>
>
> In YARN-10504 weight mode was added, however the logged information about the 
> created queues or the toString methods weren't updated accordingly. Some 
> examples:
> ParentQueue#setupQueueConfigs:
> {code:java}
>  LOG.info(queueName + ", capacity=" + this.queueCapacities.getCapacity()
>           + ", absoluteCapacity=" + this.queueCapacities.getAbsoluteCapacity()
>           + ", maxCapacity=" + this.queueCapacities.getMaximumCapacity()
>           + ", absoluteMaxCapacity=" + this.queueCapacities
>           .getAbsoluteMaximumCapacity() + ", state=" + getState() + ", acls="
>           + aclsString + ", labels=" + labelStrBuilder.toString() + "\n"
>           + ", reservationsContinueLooking=" + reservationsContinueLooking
>           + ", orderingPolicy=" + getQueueOrderingPolicyConfigName()
>           + ", priority=" + priority
>           + ", allowZeroCapacitySum=" + allowZeroCapacitySum);
> {code}
> ParentQueue#toString:
> {code:java}
> public String toString() {
>     return queueName + ": " +
>         "numChildQueue= " + childQueues.size() + ", " + 
>         "capacity=" + queueCapacities.getCapacity() + ", " +  
>         "absoluteCapacity=" + queueCapacities.getAbsoluteCapacity() + ", " +
>         "usedResources=" + queueUsage.getUsed() + 
>         "usedCapacity=" + getUsedCapacity() + ", " + 
>         "numApps=" + getNumApplications() + ", " + 
>         "numContainers=" + getNumContainers();
>  }
> {code}
> LeafQueue#setupQueueConfigs:
> {code:java}
>       LOG.info(
>           "Initializing " + getQueuePath() + "\n" + "capacity = "
>               + queueCapacities.getCapacity()
>               + " [= (float) configuredCapacity / 100 ]" + "\n"
>               + "absoluteCapacity = " + queueCapacities.getAbsoluteCapacity()
>               + " [= parentAbsoluteCapacity * capacity ]" + "\n"
>               + "maxCapacity = " + queueCapacities.getMaximumCapacity()
>               + " [= configuredMaxCapacity ]" + "\n" + "absoluteMaxCapacity = 
> "
>               + queueCapacities.getAbsoluteMaximumCapacity()
>               + " [= 1.0 maximumCapacity undefined, "
>               + "(parentAbsoluteMaxCapacity * maximumCapacity) / 100 
> otherwise ]"
>               + "\n" + "effectiveMinResource=" +
>               getEffectiveCapacity(CommonNodeLabelsManager.NO_LABEL) + "\n"
>               + " , effectiveMaxResource=" +
>               getEffectiveMaxCapacity(CommonNodeLabelsManager.NO_LABEL)
>               + "\n" + "userLimit = " + usersManager.getUserLimit()
>               + " [= configuredUserLimit ]" + "\n" + "userLimitFactor = "
>               + usersManager.getUserLimitFactor()
>               + " [= configuredUserLimitFactor ]" + "\n" + "maxApplications = 
> "
>               + maxApplications
>               + " [= configuredMaximumSystemApplicationsPerQueue or"
>               + " (int)(configuredMaximumSystemApplications * 
> absoluteCapacity)]"
>               + "\n" + "maxApplicationsPerUser = " + maxApplicationsPerUser
>               + " [= (int)(maxApplications * (userLimit / 100.0f) * "
>               + "userLimitFactor) ]" + "\n"
>               + "maxParallelApps = " + getMaxParallelApps() + "\n"
>               + "usedCapacity = " +
>               + queueCapacities.getUsedCapacity() + " [= usedResourcesMemory 
> / "
>               + "(clusterResourceMemory * absoluteCapacity)]" + "\n"
>               + "absoluteUsedCapacity = " + absoluteUsedCapacity
>               + " [= usedResourcesMemory / clusterResourceMemory]" + "\n"
>               + "maxAMResourcePerQueuePercent = " + 
> maxAMResourcePerQueuePercent
>               + " [= configuredMaximumAMResourcePercent ]" + "\n"
>               + "minimumAllocationFactor = " + minimumAllocationFactor
>               + " [= (float)(maximumAllocationMemory - 
> minimumAllocationMemory) / "
>               + "maximumAllocationMemory ]" + "\n" + "maximumAllocation = "
>               + maximumAllocation + " [= configuredMaxAllocation ]" + "\n"
>               + "numContainers = " + numContainers
>               + " [= currentNumContainers ]" + "\n" + "state = " + getState()
>               + " [= configuredState ]" + "\n" + "acls = " + aclsString
>               + " [= configuredAcls ]" + "\n"
>               + "nodeLocalityDelay = " + nodeLocalityDelay + "\n"
>               + "rackLocalityAdditionalDelay = "
>               + rackLocalityAdditionalDelay + "\n"
>               + "labels=" + labelStrBuilder.toString() + "\n"
>               + "reservationsContinueLooking = "
>               + reservationsContinueLooking + "\n" + "preemptionDisabled = "
>               + getPreemptionDisabled() + "\n" + "defaultAppPriorityPerQueue 
> = "
>               + defaultAppPriorityPerQueue + "\npriority = " + priority
>               + "\nmaxLifetime = " + getMaximumApplicationLifetime()
>               + " seconds" + "\ndefaultLifetime = "
>               + getDefaultApplicationLifetime() + " seconds");
> {code}
> ..etc. These should be extended for easier debugging or general verifications.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to