[ 
https://issues.apache.org/jira/browse/YARN-10653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291407#comment-17291407
 ] 

Qi Zhu edited comment on YARN-10653 at 2/26/21, 5:50 AM:
---------------------------------------------------------

[~ebadger] [~ahussein] 

I just find the finding bug has been fixed, the finding bug errors is in the 
trunk, but the fixed has not show finding bugs, i mistake to look at the trunk 
finding bug.
!image-2021-02-26-13-49-18-241.png|width=592,height=67!  

The patch 001, will be fine for merge, i think.

If you any other advice?

Thanks.


was (Author: zhuqi):
[~ebadger] [~ahussein] 

It confirmed the Jenkins don't realize the change in the fix, the latest patch 
have no null check in line 649, but it still show the 649 null check. 

 

> Fixed the findbugs issues introduced by YARN-10647.
> ---------------------------------------------------
>
>                 Key: YARN-10653
>                 URL: https://issues.apache.org/jira/browse/YARN-10653
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Qi Zhu
>            Assignee: Qi Zhu
>            Priority: Major
>         Attachments: YARN-10653.001.patch, YARN-10653.002.patch, 
> image-2021-02-26-13-49-18-241.png
>
>
> In YARN-10647
> I fixed TestRMNodeLabelsManager failed after YARN-10501.
> But the finding bugs should be fixed also.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to