[
https://issues.apache.org/jira/browse/YARN-10641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291708#comment-17291708
]
Andras Gyori commented on YARN-10641:
-------------------------------------
Hi [~zhuqi], thank you for the patch. I always like the idea of making the code
cleaner and fixing bugs in the meanwhile. The patch looks good to me, I have
only minor additions:
* I think testLeafQueueMaxAppUpdateWhenAutoCreation should be named
testAutoQueueCreationMaxAppUpdate (this is the convention other methods are
using)
* The assertEquals method is used the other way around. The first value is the
expected value, the second is the actual.
* LeafQueue has a TODO comment with a typo.
One thing I realised while reading your comment is that we are indeed ignoring
labeling while setting the maximum applications in a queue. As I see it, we
overwrite the maximumApplications value each time while iterating through
labels, which effectively makes the last label to dominate in the calculation.
Perhaps its worth investigating a bit.
> Refactor the max app related update, and fix maxApllications update error
> when add new queues.
> ----------------------------------------------------------------------------------------------
>
> Key: YARN-10641
> URL: https://issues.apache.org/jira/browse/YARN-10641
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Qi Zhu
> Assignee: Qi Zhu
> Priority: Critical
> Attachments: YARN-10641.001.patch, YARN-10641.002.patch,
> YARN-10641.003.patch, YARN-10641.004.patch,
> image-2021-02-20-15-49-58-677.png, image-2021-02-20-15-53-51-099.png,
> image-2021-02-20-15-55-44-780.png, image-2021-02-20-16-29-18-519.png,
> image-2021-02-20-16-31-13-714.png
>
>
> When refactor the update logic in YARN-10504 .
> The update max applications based abs/cap is wrong, this should be fixed,
> because the max applications is key part to limit applications in CS.
> For example:
> When adding a dynamic queue, the other children's max app of parent queue are
> not updated correctly:
> !image-2021-02-20-15-53-51-099.png|width=639,height=509!
> The new added queue's max app will updated correctly:
> !image-2021-02-20-15-55-44-780.png|width=542,height=426!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
