[
https://issues.apache.org/jira/browse/YARN-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17292912#comment-17292912
]
Andras Gyori commented on YARN-10532:
-------------------------------------
Hi [~zhuqi]. I have some final addition on the contribution (sorry for delaying
the commit). One major thing is:
* The auto queue removal switch is flawed. I am convinced that one would
expect to have yarn.scheduler.capacity in the property, but this is not the
case:
{code:java}
@Private
public static final String AUTO_CREATE_CHILD_QUEUE_AUTO_REMOVAL_ENABLE =
AUTO_QUEUE_CREATION_V2_PREFIX + "queue-auto-removal.enable";
{code}
There are some minor format issues in TestCapacitySchedulerNewQueueAutoCreation:
* There are still a lot of places where new Supplier<Boolean> is still used,
but sometimes it is replaced by a lambda. This is not consistent
* assertTrue(getNumApplications() == 0) asserts could be simplified to an
equals assert
Apart from those issues, the patch looks good to me.
> Capacity Scheduler Auto Queue Creation: Allow auto delete queue when queue is
> not being used
> --------------------------------------------------------------------------------------------
>
> Key: YARN-10532
> URL: https://issues.apache.org/jira/browse/YARN-10532
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Wangda Tan
> Assignee: Qi Zhu
> Priority: Major
> Attachments: YARN-10532.001.patch, YARN-10532.002.patch,
> YARN-10532.003.patch, YARN-10532.004.patch, YARN-10532.005.patch,
> YARN-10532.006.patch, YARN-10532.007.patch, YARN-10532.008.patch,
> YARN-10532.009.patch, YARN-10532.010.patch, YARN-10532.011.patch,
> YARN-10532.012.patch, YARN-10532.013.patch, YARN-10532.014.patch,
> YARN-10532.015.patch, YARN-10532.016.patch, YARN-10532.017.patch,
> YARN-10532.018.patch, YARN-10532.019.patch, YARN-10532.020.patch,
> YARN-10532.021.patch, YARN-10532.022.patch, YARN-10532.023.patch,
> YARN-10532.024.patch, image-2021-02-12-21-32-02-267.png
>
>
> It's better if we can delete auto-created queues when they are not in use for
> a period of time (like 5 mins). It will be helpful when we have a large
> number of auto-created queues (e.g. from 500 users), but only a small subset
> of queues are actively used.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
