[
https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17294705#comment-17294705
]
Peter Bacsko commented on YARN-9615:
------------------------------------
Thanks [~zhuqi] for the patch.
Minor things left:
1. {{GenericTestUtils.waitFor()}} --> remove the anonymous inner classes and
use lambdas.
2. {{AsyncDispatcher}} is not closed in the tests. It's important to close it
because it starts a thread.
Do this:
{noformat}
AsyncDispatcher dispatcher = null;
try {
... test code
} finally {
if (dispatcher != null) {
dispatcher.close();
}
}
{noformat}
3.
{noformat}
/**
* Run a test to submit values for Dispatcher metrics
* histogram comes out correctly.
* @throws Exception
*/
{noformat}
This comment can be removed, the test name says what it does.
> Add dispatcher metrics to RM
> ----------------------------
>
> Key: YARN-9615
> URL: https://issues.apache.org/jira/browse/YARN-9615
> Project: Hadoop YARN
> Issue Type: Task
> Reporter: Jonathan Hung
> Assignee: Qi Zhu
> Priority: Major
> Attachments: YARN-9615.001.patch, YARN-9615.002.patch,
> YARN-9615.003.patch, YARN-9615.004.patch, YARN-9615.005.patch,
> YARN-9615.006.patch, YARN-9615.007.patch, YARN-9615.poc.patch,
> screenshot-1.png
>
>
> It'd be good to have counts/processing times for each event type in RM async
> dispatcher and scheduler async dispatcher.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
