[ 
https://issues.apache.org/jira/browse/YARN-10687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17299827#comment-17299827
 ] 

Jim Brennan commented on YARN-10687:
------------------------------------

Thanks for updating [~zhuqi]!  Can you please add a unit test to 
TestDirectoryCollection?  Also, did you see [~gandras]'s suggestion about 
changing the property names?  e.g., {{disk-utilization-percentage.enabled}}?

> Add option to disable/enable free disk space checking and percentage checking 
> for full and not-full disks
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-10687
>                 URL: https://issues.apache.org/jira/browse/YARN-10687
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 3.2.2, 3.4.0
>            Reporter: Qi Zhu
>            Assignee: Qi Zhu
>            Priority: Major
>         Attachments: YARN-10687.001.patch, YARN-10687.002.patch
>
>
> Now the two option:
> max-disk-utilization-per-disk-percentage
>  min-free-space-per-disk-mb
> for full/not full disk check are all enabled always, i think it's more 
> reasonable to enable or disable this, and default will be all enabled.
>  
> In our clusters, when the disk is so huge we want to use  
> min-free-space-per-disk-mb.
> In our clusters,  when the disk is so small we want to use 
> max-disk-utilization-per-disk-percentage.
>  
> We should make this more reasonable and not confused.
>  
> cc [~pbacsko]  [~Jim_Brennan]  [~ebadger]  [~gandras] 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to