[ 
https://issues.apache.org/jira/browse/YARN-10659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17304077#comment-17304077
 ] 

Szilard Nemeth commented on YARN-10659:
---------------------------------------

Thanks [~shuzirra] for working on this.
Latest patch LGTM, committed to trunk.
Checkstyle issue is not important and javadoc issue was not related.
Thanks [~gandras] for the review.

> Improve CS MappingRule %secondary_group evaluation
> --------------------------------------------------
>
>                 Key: YARN-10659
>                 URL: https://issues.apache.org/jira/browse/YARN-10659
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Gergely Pollak
>            Assignee: Gergely Pollak
>            Priority: Major
>         Attachments: YARN-10659.001.patch, YARN-10659.002.patch, 
> YARN-10659.003.patch
>
>
> Since the leaf queue names are not unique, there are a lot of use cases where 
> %secondary_group evaluation fail, or behave inconsistently.
> We should extend it's behavior, when it's under a defined parent, 
> %secondary_group evaluation should only check for queue existence under that 
> queue. Egy root.group.%secondary_group, should only evaluate to groups which 
> exist under root.group, while the legacy %secondary_group.%user should still 
> look for groups by their leaf name globally.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to