[
https://issues.apache.org/jira/browse/YARN-10503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309058#comment-17309058
]
Eric Badger commented on YARN-10503:
------------------------------------
Thanks for the patch, [~zhuqi]! Here are a few comments
{noformat}
+ if (ResourceUtils.getNumberOfKnownResourceTypes() > 2) {
+ ResourceInformation[] resources =
+ resource.getResources();
+ for (int i = 2; i < resources.length; i++) {
+ ResourceInformation resInfo = resources[i];
+ resourceString.append(","
+ + resInfo.getName() + "=" + resInfo.getValue());
+ }
+ }
{noformat}
This code snippet is repeated a lot of different times in this patch. I think
it would make sense to make this into a method so that we don't have so much
code repetition.
{{splits[0]}} is used enough in the code that I think it makes sense to make it
into a local variable for better readability.
> Support queue capacity in terms of absolute resources with custom
> resourceType.
> -------------------------------------------------------------------------------
>
> Key: YARN-10503
> URL: https://issues.apache.org/jira/browse/YARN-10503
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Qi Zhu
> Assignee: Qi Zhu
> Priority: Critical
> Attachments: YARN-10503.001.patch, YARN-10503.002.patch,
> YARN-10503.003.patch, YARN-10503.004.patch, YARN-10503.005.patch,
> YARN-10503.006.patch
>
>
> Now the absolute resources are memory and cores.
> {code:java}
> /**
> * Different resource types supported.
> */
> public enum AbsoluteResourceType {
> MEMORY, VCORES;
> }{code}
> But in our GPU production clusters, we need to support more resourceTypes.
> It's very import for cluster scaling when with different resourceType
> absolute demands.
>
> This Jira will handle GPU first.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
