[ 
https://issues.apache.org/jira/browse/YARN-10657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315348#comment-17315348
 ] 

Andras Gyori commented on YARN-10657:
-------------------------------------

Thank you [~zhuqi] for working on this issue. After analysing the affected code 
I have the following concerns:
 * The current approach is not a true node label support, it is still using a 
single maxApplication value for all nodeLabels. I am not sure if the current 
approach would make anything better, but could easily create confusion.
 * To be able to support true nodeLabels, one would need to store  a 
maxApplication value for each nodeLabel (eg. in a Map). However, as I see it, 
on application submission, where this maxApplication is retrieved and used as 
some sort of validation in the queue, we do not have a reference to the node 
label. I think it would involve too much work for a feature that is not a high 
priority item.

> We should make max application per queue to support node label.
> ---------------------------------------------------------------
>
>                 Key: YARN-10657
>                 URL: https://issues.apache.org/jira/browse/YARN-10657
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Qi Zhu
>            Assignee: Qi Zhu
>            Priority: Major
>         Attachments: YARN-10657.001.patch, YARN-10657.002.patch
>
>
> https://issues.apache.org/jira/browse/YARN-10641?focusedCommentId=17291708&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17291708
> As we discussed in above comment:
> We should deep into the label related max applications per queue.
> I think when node label enabled in queue, max applications should consider 
> the max capacity of all labels.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to