[
https://issues.apache.org/jira/browse/YARN-10564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17316309#comment-17316309
]
Peter Bacsko commented on YARN-10564:
-------------------------------------
Thanks [~gandras] I have the following suggestions: please add comments to the
"for" loop which explains this. I don't want to dictate the wording. It could
be more sentences. I think it's important. Also, maybe also comment that
"supportedWildcardLevel" or MAX_WILDCARD_LEVEL might change in the future (just
like me, people might realize that the range is [0-1] and it might make people
confused).
Also, an overall comment like "collect all template settings based on prefix,
then finally apply the collected settings to the newly created queue" might be
useful. I'd put it somewhere before the "while" loop, but this is just an idea.
> Support Auto Queue Creation template configurations
> ---------------------------------------------------
>
> Key: YARN-10564
> URL: https://issues.apache.org/jira/browse/YARN-10564
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Andras Gyori
> Assignee: Andras Gyori
> Priority: Major
> Attachments: YARN-10564.001.patch, YARN-10564.002.patch,
> YARN-10564.003.patch, YARN-10564.004.patch, YARN-10564.005.patch,
> YARN-10564.poc.001.patch
>
>
> Similar to how the template configuration works for ManagedParents, we need
> to support templates for the new auto queue creation logic. Proposition is to
> allow wildcards in template configs such as:
> {noformat}
> yarn.scheduler.capacity.root.*.*.weight 10{noformat}
> which would mean, that set weight to 10 of every leaf of every parent under
> root.
> We should possibly take an approach, that could support arbitrary depth of
> template configuration, because we might need to lift the limitation of auto
> queue nesting.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
