[
https://issues.apache.org/jira/browse/YARN-10715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325387#comment-17325387
]
Eric Badger commented on YARN-10715:
------------------------------------
Finally getting around to looking at this and I don't think removing the
hardcoded values from ResourceUtils is necessary. It's not necessary for the
resource translation to be there for GPUs and FPGAs, but it also doesn't hurt
anything. I'm not quite sure why {{yarn.io/gpu}} was chosen anyway, since that
seems like a pretty complex name for something as simple as a gpu. But I'm sure
there was a good reason.
Anyway, we should definitely strive to remove any code that is hardcoding
calculations for GPUs/FPGAs and generalize them to any extended resource type.
But in this case, this is just a simple translation from {{gpu}} to
{{yarn.io/gpu}} and similarily for FPGAs. I'm inclined to close this as won't do
> Remove hardcoded resource values (e.g. GPU/FPGA) in code.
> ---------------------------------------------------------
>
> Key: YARN-10715
> URL: https://issues.apache.org/jira/browse/YARN-10715
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Qi Zhu
> Assignee: Qi Zhu
> Priority: Major
> Attachments: YARN-10715.001.patch
>
>
> https://issues.apache.org/jira/browse/YARN-10503?focusedCommentId=17307772&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17307772
> As above comment , we should remove hardcoded resource values (e.g. GPU/FPGA)
> in code.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
